This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
build!: update to latest version of gts and typescript #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 99.80% 99.80% -0.01%
==========================================
Files 20 20
Lines 11739 11727 -12
==========================================
- Hits 11716 11704 -12
Misses 23 23
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Apr 13, 2020
.prettierignore
Outdated
| **/.coverage | ||
| build/ | ||
| docs/ | ||
| protos/ |
There was a problem hiding this comment.
Please add a newline at the end to get rid of the squiggle
package.json
Outdated
| @@ -54,14 +54,17 @@ | |||
| "eslint-config-prettier": "^6.0.0", | |||
| "eslint-plugin-node": "^11.0.0", | |||
| "eslint-plugin-prettier": "^3.0.0", | |||
| "gts": "^2.0.0-alpha.5", | |||
There was a problem hiding this comment.
We can drop the -alpha.5 part here since 2.0 is out
package.json
Outdated
| @@ -54,14 +54,17 @@ | |||
| "eslint-config-prettier": "^6.0.0", | |||
There was a problem hiding this comment.
Please delete all the eslint- packages, and the prettier package
There was a problem hiding this comment.
Hey @JustinBeckwith! Just want to make sure I'm understanding correctly. Did you want me to delete .eslintignore, .eslintrc.json, .prettierignore and .prettierrc.js? I was using this PR as reference, I know Ben left those there.
There was a problem hiding this comment.
Oh noes! Leave those files. I'm saying the package references in the devDependencies section of package.json. Those are transitive dependencies of gts, so we can delete em from here.
Keep all the files!
JustinBeckwith
added
the
needs work
… into updateGTSandTS
… into updateGTSandTS
JustinBeckwith
approved these changes
Apr 15, 2020
JustinBeckwith
removed
the
needs work
Merged
yoshi-automation
added a commit
that referenced
this pull request
Apr 16, 2020
Source-Author: sofisl <[email protected]> Source-Date: Wed Apr 15 12:40:42 2020 -0700 Source-Repo: googleapis/nodejs-compute Source-Sha: a4fa8cc Source-Link: a4fa8cc
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 5, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://github.com/googleapis/nodejs-compute/compare/v1.2.0...v2.0.0) (2020-05-08) ### ⚠ BREAKING CHANGES * update to latest version of gts and typescript (#433) * require node 10 in engines field (#431) ### Features * require node 10 in engines field ([#431](https://github.com/googleapis/nodejs-compute/issues/431)) ([fe2897f](https://github.com/googleapis/nodejs-compute/commit/fe2897fd1d625df0ccf5b910ec850e761c2ed6d3)) ### Bug Fixes * apache license URL ([#468](https://github.com/googleapis/nodejs-compute/issues/468)) ([#427](https://github.com/googleapis/nodejs-compute/issues/427)) ([02d63ed](https://github.com/googleapis/nodejs-compute/commit/02d63ed5a5a3559be0b5e49ed4c771b3661518a1)) * **deps:** update dependency @google-cloud/common to v3 ([#421](https://github.com/googleapis/nodejs-compute/issues/421)) ([d4469b6](https://github.com/googleapis/nodejs-compute/commit/d4469b693745df5a8a36b6988b7dba98f7d55142)) * **deps:** update dependency @google-cloud/paginator to v3 ([#419](https://github.com/googleapis/nodejs-compute/issues/419)) ([e667aee](https://github.com/googleapis/nodejs-compute/commit/e667aeecf7b9f51875c06cb6a885040828dc1181)) * **deps:** update dependency @google-cloud/projectify to v2 ([#418](https://github.com/googleapis/nodejs-compute/issues/418)) ([b861540](https://github.com/googleapis/nodejs-compute/commit/b861540aa17118a7508c7c970d84864a9028f588)) * **deps:** update dependency @google-cloud/promisify to v2 ([#417](https://github.com/googleapis/nodejs-compute/issues/417)) ([eedce75](https://github.com/googleapis/nodejs-compute/commit/eedce75e0d3f10dfed8151f12150d38d032f6a27)) * **deps:** update dependency @sendgrid/mail to v7 ([#424](https://github.com/googleapis/nodejs-compute/issues/424)) ([17af0f4](https://github.com/googleapis/nodejs-compute/commit/17af0f425354b261f9afc8ab30e16e66b7193fec)) ### Build System * update to latest version of gts and typescript ([#433](https://github.com/googleapis/nodejs-compute/issues/433)) ([a4fa8cc](https://github.com/googleapis/nodejs-compute/commit/a4fa8cc21df7a894486832b05449fa7afc02b7ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.