Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getWriteStream and createWriteStreamFullResponse methods #453

Merged
merged 6 commits into from
May 8, 2024
Merged

feat: add getWriteStream and createWriteStreamFullResponse methods #453

merged 6 commits into from
May 8, 2024

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented May 6, 2024 •
edited
Loading

Add wrapper for getWriteStream method. We can changes samples to use this method to get the table schema, instead of using the other BigQuery Node library.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels May 6, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 6, 2024
@alvarowolfx alvarowolfx marked this pull request as ready for review May 6, 2024 19:07
@alvarowolfx alvarowolfx requested review from a team as code owners May 6, 2024 19:07
@alvarowolfx alvarowolfx requested review from leahecole, shollyman and yirutang and removed request for leahecole May 6, 2024 19:07
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
yirutang
yirutang reviewed May 6, 2024
View reviewed changes
@alvarowolfx alvarowolfx changed the title feat: add getWriteStream method feat: add getWriteStream and createWriteStreamFullResponse methods May 6, 2024
@alvarowolfx alvarowolfx mentioned this pull request May 6, 2024
Merged
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 7, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
shollyman
shollyman approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we didn't need the custom name for the full creation response, but alas this seems a reasonable way to get around it without breaking usage.

@alvarowolfx alvarowolfx merged commit 27dce6a into googleapis:main May 8, 2024
14 checks passed
@release-please release-please bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang left review comments

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarowolfx @shollyman @yirutang @yoshi-kokoro