Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat!: drop node8 support, support for async iterators #299

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Mar 31, 2020

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE

The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #299 into master will increase coverage by 5.02%.
The diff coverage is 99.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   91.22%   96.24%   +5.02%     
==========================================
  Files          11       11              
  Lines        3782     4045     +263     
  Branches      203      230      +27     
==========================================
+ Hits         3450     3893     +443     
+ Misses        327      147     -180     
  Partials        5        5              
Impacted Files Coverage Δ
src/v1p1beta1/asset_service_client.ts 95.53% <96.87%> (+3.87%) ⬆️
src/v1/asset_service_client.ts 97.18% <100.00%> (+5.00%) ⬆️
src/v1beta1/asset_service_client.ts 95.24% <100.00%> (+3.74%) ⬆️
src/v1p2beta1/asset_service_client.ts 96.55% <100.00%> (+8.33%) ⬆️
src/v1p4beta1/asset_service_client.ts 94.92% <100.00%> (+3.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3386ef8...9421220. Read the comment docs.

@alexander-fenster alexander-fenster requested a review from bcoe March 31, 2020 11:13
@bcoe bcoe merged commit ae14ae8 into master Mar 31, 2020
@bcoe bcoe deleted the finally-drop-node8 branch March 31, 2020 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants