-
Notifications
You must be signed in to change notification settings - Fork 25
feat!: converts library to TypeScript adding v1p1beta1 surface #250
Conversation
I will take a look, thank you! |
@bcoe Unfortunately, asset API versions other than If you'd like to, we can combine TypeScript |
This API version was added on Jan 06, 2020 and I didn't know, so I will need to annotate and publish. It will be done this week, I'll try to get it done sooner rather than later. |
Asset v1p1beta1 was annotated and published here googleapis/googleapis@26ccb21. |
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
===========================================
+ Coverage 35.35% 90.89% +55.53%
===========================================
Files 39 9 -30
Lines 6624 3392 -3232
Branches 0 151 +151
===========================================
+ Hits 2342 3083 +741
+ Misses 4282 305 -3977
- Partials 0 4 +4
Continue to review full report at Codecov.
|
// This API contains "path templates"; forward-slash-separated | ||
// identifiers to uniquely identify resources within the API. | ||
// Create useful helper objects for these. | ||
this._pathTemplates = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of path templates is different (if you compare it with the deleted src/v1/asset_service_client.js
). Let me double check if the new path templates are correct in the annotations. For now, please mark this PR as feat!
because it now has breaking changes.
output: { | ||
library: 'asset', | ||
filename: './asset.js', | ||
library: 'AssetService', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a breaking change to Webpack users. If we're breaking it anyway (which is what is likely to happen), let's keep this. If we want to be compatible, we'll need --main-service-name asset
as an extra generator arg. But I'd better break it since there are no active Webpack users here as I'm pretty sure :)
converts library to TypeScript, so that we can generate
v1p1beta1
which uses the new type annotations.Currently there are the following generation issues that need to be addressed: