This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
fix!: Fix the resource annotations for GetRepositoryRequest #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway. PiperOrigin-RevId: 403028264 Source-Link: googleapis/googleapis@9bac62d Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f54454b649bcedea14bb01955a65850ce906d9b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: artifactregistry
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
SurferJeffAtGoogle
approved these changes
Oct 14, 2021
SurferJeffAtGoogle
deleted the
owl-bot-bd879787-63de-4c15-9681-cd0dcc296138
branch
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://github.com/googleapis/nodejs-artifact-registry/compare/v1.2.0...v1.2.1) (2021-10-14) ### ⚠ BREAKING CHANGES * * fix!: Fix the resource annotations for GetRepositoryRequest ### Bug Fixes * Fix the resource annotations for GetRepositoryRequest ([#88](https://github.com/googleapis/nodejs-artifact-registry/issues/88)) ([80ba28f](https://github.com/googleapis/nodejs-artifact-registry/commit/80ba28f3d3df7ac211edd82b10bb966f61f787f6)) ### meta * release at 1.2.1 ([#90](https://github.com/googleapis/nodejs-artifact-registry/issues/90)) ([314bef4](https://github.com/googleapis/nodejs-artifact-registry/commit/314bef484ad3cc0aa7f673c9674115689f529d88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway.
PiperOrigin-RevId: 403028264
Source-Link: googleapis/googleapis@9bac62d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f54454b649bcedea14bb01955a65850ce906d9b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9