Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong HttpStorageRpcSpans.SPAN_NAME_LIST_OBJECTS value? #942

Closed
mwojterski opened this issue Aug 4, 2021 · 1 comment · Fixed by #946
Closed

Wrong HttpStorageRpcSpans.SPAN_NAME_LIST_OBJECTS value? #942

mwojterski opened this issue Aug 4, 2021 · 1 comment · Fixed by #946
Assignees
@BenWhitehead
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mwojterski
Copy link

java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpcSpans.java

Line 30 in 5e99061

static final String SPAN_NAME_LIST_OBJECTS = getTraceSpanName("create(String,Map)");

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Aug 4, 2021
@BenWhitehead BenWhitehead self-assigned this Aug 4, 2021
@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 4, 2021
@BenWhitehead
Copy link
Collaborator

Thanks for bringing this to our attention, I'll consult with some folks and hopefully have a fix.

@BenWhitehead BenWhitehead mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWhitehead BenWhitehead

Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrectly labeled span list(String,Map)
2 participants
@mwojterski @BenWhitehead