feat: Remove client side vaildation for lifecycle conditions #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
JesseLovelace
changed the title
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
=========================================
Coverage 64.61% 64.62%
+ Complexity 634 625 -9
=========================================
Files 32 32
Lines 5313 5314 +1
Branches 519 520 +1
=========================================
+ Hits 3433 3434 +1
Misses 1718 1718
Partials 162 162
Continue to review full report at Codecov.
|
tritone
reviewed
May 11, 2021
| + "management. Please see https://cloud.google.com/storage/docs/lifecycle for details."); | ||
| log.warning("Creating a lifecycle condition with no supported conditions:\n" | ||
| + this | ||
| + "\nAttempting to update with this rule may cause errors."); |
There was a problem hiding this comment.
I would suggest updating the client version, maybe a similar message to what we have in python: googleapis/python-storage#437
BenWhitehead
approved these changes
May 11, 2021
tritone
approved these changes
May 11, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.114.0](https://github.com/googleapis/java-storage/compare/v1.113.16...v1.114.0) (2021-05-13) ### Features * Remove client side vaildation for lifecycle conditions ([#816](https://github.com/googleapis/java-storage/issues/816)) ([5ec84cc](https://github.com/googleapis/java-storage/commit/5ec84cc2935a4787dd14a207d27501878f5849d5)) ### Bug Fixes * **test:** update blob paths used in storage.it.ITStorageTest#testDownloadPublicBlobWithoutAuthentication ([#759](https://github.com/googleapis/java-storage/issues/759)) ([#817](https://github.com/googleapis/java-storage/issues/817)) ([1a576ca](https://github.com/googleapis/java-storage/commit/1a576ca3945b51d7a678aa2414be91b3c6b2d55e)) ### Dependencies * update dependency com.google.api-client:google-api-client to v1.31.5 ([#820](https://github.com/googleapis/java-storage/issues/820)) ([9e1bc0b](https://github.com/googleapis/java-storage/commit/9e1bc0b42abdaab0b11d761ecdbb92f6116aacd2)) * update dependency com.google.api.grpc:grpc-google-cloud-kms-v1 to v0.88.3 ([#797](https://github.com/googleapis/java-storage/issues/797)) ([747e7e4](https://github.com/googleapis/java-storage/commit/747e7e463c028b9cf8a406b7536b1916c1d52c01)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#815](https://github.com/googleapis/java-storage/issues/815)) ([e210de9](https://github.com/googleapis/java-storage/commit/e210de93452243242be7d3d719d00da723632335)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Super late comment here but can we add tests for this? @JesseLovelace |
BenWhitehead
added a commit
that referenced
this pull request
Sep 28, 2021
* feat: Remove client side vaildation for lifecycle conditions (#816) * Remove client side vaildation for lifecycle conditions * fix lint and suggest updating (cherry picked from commit 5ec84cc) * fix: update BucketInfo translation code to properly handle lifecycle rules (#852) Fixes #850 (cherry picked from commit 3b1df1d) * fix: improve error detection and reporting for BlobWriteChannel retry state (#846) Add new checks to ensure a more informative error than NullPointerException is thrown if the StorageObject or it's size are unable to be resolved on the last chunk. Fixes #839 (cherry picked from commit d0f2184) * fix: correct lastChunk retry logic in BlobWriteChannel (#918) Add new method StorageRpc#queryResumableUpload which allows getting a shallow StorageObject for a resumable upload session which is complete. Update BlobWriteChannel to use StoageRpc#queryResumableUpload instead of StorageRpc#get when attempting to validate the upload size of an object when it determines the upload is complete and is on the last chunk. If a BlobWriteChannel is opened with a conditional like IfGenerationMatch it is not possible to simply get the object, as the object can drift generationally while the resumable upload is being performed. Related to #839 (cherry picked from commit ab0228c) * test: remove error string matching (#861) It looks like the text for this error on the backend has changed (sometimes) from "Precondition Failed" to "At least one of the pre-conditions you specified did not hold". I don't think it's really necessary to check the exact message in any case given that we do check for a code of 412, which implies a precondition failure. I added a check of the error Reason instead, which is more standardized. Fixes #853 (cherry picked from commit 146a3d3) Co-authored-by: JesseLovelace <[email protected]> Co-authored-by: Chris Cotter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces exception for empty lifecycle condition with a warning.