Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: Accept x-goog-meta-* as metadata value in PostPolicyV4 #394

Closed
frankyn opened this issue Jun 25, 2020 · 1 comment · Fixed by #398
Closed

Support: Accept x-goog-meta-* as metadata value in PostPolicyV4 #394

frankyn opened this issue Jun 25, 2020 · 1 comment · Fixed by #398
Assignees
@dmitry-fa
Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Contributor

frankyn commented Jun 25, 2020

Allow field parameter to pass in x-goog-meta-* as field name:

https://github.com/googleapis/java-storage/blob/master/google-cloud-storage/src/main/java/com/google/cloud/storage/PostPolicyV4.java#L139

It would support both x-goog-meta-* prefixed fields and not prefixed fields.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Jun 25, 2020
@frankyn frankyn changed the title Support: Accept x-goog-meta-* as metadata value in Support: Accept x-goog-meta-* as metadata value in PostPolicyV4 Jun 25, 2020
@frankyn frankyn added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 25, 2020
@frankyn
Copy link
Contributor Author

frankyn commented Jun 25, 2020

@dmitry-fa want to pick this up?

@dmitry-fa dmitry-fa self-assigned this Jun 28, 2020
@dmitry-fa dmitry-fa mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-fa dmitry-fa

Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@frankyn @dmitry-fa