Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Fix flake in PubsubLiteSourceReaderTest #44

Merged
merged 2 commits into from
Jul 29, 2021
Merged

fix(test): Fix flake in PubsubLiteSourceReaderTest #44

merged 2 commits into from
Jul 29, 2021

Conversation

palmere-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner July 29, 2021 17:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@palmere-google palmere-google changed the title fix: Fix flake in PubsubLiteSourceReaderTest fix 43: Fix flake in PubsubLiteSourceReaderTest Jul 29, 2021
@palmere-google palmere-google changed the title fix 43: Fix flake in PubsubLiteSourceReaderTest fix(test): Fix flake in PubsubLiteSourceReaderTest Jul 29, 2021
@anguillanneuf anguillanneuf merged commit 09871f3 into master Jul 29, 2021
@anguillanneuf anguillanneuf deleted the test-fix branch July 29, 2021 17:33
@palmere-google palmere-google mentioned this pull request Jul 29, 2021
Closed
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palmere-google @anguillanneuf