feat: integration test for the psl sink and source #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
palmere-google
force-pushed
the
palmere-dev-test
branch
5 times, most recently
from
6c930f1 to
f7008c6
Compare
| .collect(Collectors.toList())) | ||
| .get(); | ||
|
|
||
| while (CollectSink.values().size() < 100) { |
There was a problem hiding this comment.
fewer magic constants if you could- I think INTEGER_STRINGS.size()?
There was a problem hiding this comment.
Yeah that's much clearer
|
|
||
| Publisher<MessageMetadata> publisher = getPublisher(); | ||
|
|
||
| StreamExecutionEnvironment env = |
|
|
||
| // A testing sink which stores messages in a static map to prevent them from being lost when | ||
| // the sink is serialized. | ||
| private static class CollectSink implements SinkFunction<String>, Serializable { |
There was a problem hiding this comment.
make its own class- independently useful
There was a problem hiding this comment.
Will do in another pr
| // the sink is serialized. | ||
| private static class CollectSink implements SinkFunction<String>, Serializable { | ||
| // Note: doesn't store duplicates. | ||
| private static final Set<String> collector = Collections.synchronizedSet(new HashSet<>()); |
There was a problem hiding this comment.
nit. Instead, I'd use a private static local HashSet, and add synchronized on the methods
There was a problem hiding this comment.
I'm going to nack this. It's a bit weird since there are some instance methods and some class methods - I think using synchronized invites someone to hold an object level lock when they should be holding the class lock
dpcollins-google
approved these changes
Aug 12, 2021
palmere-google
force-pushed
the
palmere-dev-test
branch
from
f7008c6 to
19dda49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️