feat: add the pubsublite sink #21
Conversation
google-cla
bot
added
the
cla: yes
| } | ||
|
|
||
| @Override | ||
| public Message serialize(T value, Instant timestamp) { |
There was a problem hiding this comment.
should this be used as the event timestamp field?
There was a problem hiding this comment.
Oh, yeah, good point! Done (in the serialize pr)
|
|
||
| @Override | ||
| public Message serialize(T value, Instant timestamp) { | ||
| return Message.fromProto( |
There was a problem hiding this comment.
Nit, use the builder methods on Message
| import java.io.Serializable; | ||
|
|
||
| @AutoValue | ||
| public abstract class PubsubLiteSinkSettings<IN> implements Serializable { |
palmere-google
force-pushed
the
palmere-dev-sink
branch
2 times, most recently
from
6a7f71e to
afa3ca5
Compare
palmere-google
force-pushed
the
palmere-dev-sink
branch
from
afa3ca5 to
48ea653
Compare
| <dependency> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-runtime_2.11</artifactId> | ||
| <version>1.13.0</version> |
There was a problem hiding this comment.
nit. add a property "flink.version" and use it everywhere you have 1.13.0. See pubsublite-beam-io for an example.
There was a problem hiding this comment.
Will do in another pr, tianzi suggested that I do this for pubsublite too
|
|
||
| @Override | ||
| public synchronized void snapshotState( | ||
| org.apache.flink.runtime.state.FunctionSnapshotContext functionSnapshotContext) |
There was a problem hiding this comment.
Why not import these?
There was a problem hiding this comment.
Done. Intellij generated them like this and I never changed them
| public abstract Builder<InputT> setTopicPath(TopicPath value); | ||
|
|
||
| abstract Builder<InputT> setSerializationSchema(PubsubLiteSerializationSchema<InputT> value); | ||
|
|
There was a problem hiding this comment.
is this the proper user interface? If so, add comments.
There was a problem hiding this comment.
Added comments.
| return new AutoValue_PubsubLiteSinkSettings.Builder<InputT>().setSerializationSchema(schema); | ||
| } | ||
|
|
||
| public static PubsubLiteSinkSettings.Builder<Message> messagesBuilder() { |
There was a problem hiding this comment.
Done, better, thanks
|
|
||
| @AutoValue | ||
| public abstract class PubsubLiteSinkSettings<InputT> implements Serializable { | ||
| public static <InputT> PubsubLiteSinkSettings.Builder<InputT> builder( |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️