feat: add the DeserializingSplitReader #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
src/main/java/com/google/cloud/pubsublite/flink/reader/DeserializingSplitReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/flink/reader/DeserializingSplitReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/flink/MessageTimestampExtractor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/flink/reader/DeserializingSplitReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/flink/reader/DeserializingSplitReader.java
Outdated
Show resolved
Hide resolved
| * @param message The pub/sub lite message | ||
| * @return The deserialized message as an object (null if the message cannot be deserialized). | ||
| */ | ||
| T deserialize(SequencedMessage message) throws Exception; |
There was a problem hiding this comment.
Mark as @Nullable
| String split = entry.getKey(); | ||
| SequencedMessage message = entry.getValue(); | ||
| try { | ||
| T value = schema.deserialize(message); |
There was a problem hiding this comment.
mark as @Nullable
|
|
||
| public abstract Offset offset(); | ||
|
|
||
| public abstract long timestamp(); |
There was a problem hiding this comment.
use Instant until you absolutely need to convert to millis
| }; | ||
| } | ||
|
|
||
| long timestampMillis(SequencedMessage m) throws Exception; |
There was a problem hiding this comment.
change to "Instant timestamp" since we're just passing this to our own type. Only transform to millis at the last possible moment
There was a problem hiding this comment.
Yeah, that's way better. I dunno what I was doing passing longs around. Done
dpcollins-google
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️