Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup CPS source subscription in tearDown() #165

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

samarthsingal
Copy link
Contributor

@samarthsingal samarthsingal commented Oct 25, 2022

Cleans up CPS source subscription which was earlier missed

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 25, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@samarthsingal samarthsingal changed the title chore: Cleanup CPS source subscription in tearDown() fix: Cleanup CPS source subscription in tearDown() Oct 25, 2022
@anguillanneuf
Copy link
Collaborator

LGTM. You need to edit your commit message to something like fix: Cleanup CPS source subscription in tearDown() pass the conventional commits check.

@samarthsingal samarthsingal added the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2022
@anguillanneuf anguillanneuf marked this pull request as ready for review October 25, 2022 18:07
@anguillanneuf anguillanneuf requested a review from a team as a code owner October 25, 2022 18:07
@anguillanneuf anguillanneuf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 73d5dcb into main Oct 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the minor_cleanup_2 branch October 25, 2022 18:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants