This repository has been archived by the owner on Sep 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
feat: updates library for v1 service #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
============================================
- Coverage 78.23% 78.06% -0.18%
- Complexity 707 1402 +695
============================================
Files 49 97 +48
Lines 5133 10158 +5025
Branches 69 137 +68
============================================
+ Hits 4016 7930 +3914
- Misses 1028 2051 +1023
- Partials 89 177 +88
Continue to review full report at Codecov.
|
chingor13
suggested changes
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change
chingor13
suggested changes
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: need to add the v1 entry to the root versions.txt
as well
Co-authored-by: Jeff Ching <[email protected]>
chingor13
approved these changes
Feb 20, 2021
lucaswadedavis
approved these changes
Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the library with v1 service types and enhanced types.