Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Add mergeFields option to set #6544

Closed
crwilcox opened this issue Nov 16, 2018 · 4 comments
Closed

[Firestore] Add mergeFields option to set #6544

crwilcox opened this issue Nov 16, 2018 · 4 comments
Assignees
@crwilcox
Labels
api: firestore Issues related to the Firestore API. triaged for GA

Comments

@crwilcox
Copy link
Contributor

This may be related to #6307

set(..., merge:true) exists, but set(..., mergeFields:[..]) does not.
We originally only added mergeFields in clients that supported POJO mapping, but have since added this option to all SDKs.
@crwilcox crwilcox added api: firestore Issues related to the Firestore API. triaged for GA labels Nov 16, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

At this point, merge can be one of True, False, or a list of field paths. If they insist on having 'mergePaths' as a separate argument, we can accomodate it.

@schmidt-sebastian
Copy link

I think the current implementation is fine as is. I missed that it can be a list of field paths.

@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

Cool -- we have conformance tests for it as it stands.

@crwilcox
Copy link
Contributor Author

Closing as by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
api: firestore Issues related to the Firestore API. triaged for GA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @crwilcox @schmidt-sebastian