Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent nox session names #4645

Closed
duggelz opened this issue Dec 20, 2017 · 3 comments
Closed

Inconsistent nox session names #4645

duggelz opened this issue Dec 20, 2017 · 3 comments
Assignees
@lukesneeringer
Labels
api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. api: container Issues related to the Kubernetes Engine API API. api: dataproc Issues related to the Dataproc API. testing type: cleanup An internal cleanup or hygiene concern.

Comments

@duggelz
Copy link

duggelz commented Dec 20, 2017

These three nox.py files have not been updated to use the new session names like unit(py='2.7'), and still use the old names like unit_tests(py='2.7')

  • bigquery_datatransfer/nox.py
  • container/nox.py
  • dataproc/nox.py
@chemelnucfin chemelnucfin self-assigned this Dec 20, 2017
@dhermes
Copy link
Contributor

dhermes commented Dec 20, 2017

@lukesneeringer This is also a de-facto bug report for the generator.

@tseaver tseaver added testing type: cleanup An internal cleanup or hygiene concern. api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. api: container Issues related to the Kubernetes Engine API API. api: dataproc Issues related to the Dataproc API. labels Dec 21, 2017
@chemelnucfin chemelnucfin removed their assignment Dec 27, 2017
@chemelnucfin
Copy link
Contributor

chemelnucfin commented Dec 27, 2017 •
edited
Loading

The manual change is #4646,
the autogenerator change is here
https://github.com/googleapis/toolkit/issues/1768

@chemelnucfin
Copy link
Contributor

Since this is now tracked in Cleanup and also is reported in the toolkit repository, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. api: container Issues related to the Kubernetes Engine API API. api: dataproc Issues related to the Dataproc API. testing type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lukesneeringer @tseaver @dhermes @duggelz @chemelnucfin