Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Firestore] bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes #8024

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 17, 2025

  • Regenerate this pull request now.

feat: add filter argument to FirestoreAdmin.ListBackupsRequest

PiperOrigin-RevId: 716763143

Source-Link: googleapis/googleapis@3776db1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/10db5ac476a94aa4c9e0a24946d9fa1b7ea456f6
Copy-Tag: eyJwIjoiRmlyZXN0b3JlLy5Pd2xCb3QueWFtbCIsImgiOiIxMGRiNWFjNDc2YTk0YWE0YzllMGEyNDk0NmQ5ZmExYjdlYTQ1NmY2In0=

… minutes

feat: add filter argument to FirestoreAdmin.ListBackupsRequest

PiperOrigin-RevId: 716763143

Source-Link: googleapis/googleapis@3776db1

Source-Link: googleapis/googleapis-gen@10db5ac
Copy-Tag: eyJwIjoiRmlyZXN0b3JlLy5Pd2xCb3QueWFtbCIsImgiOiIxMGRiNWFjNDc2YTk0YWE0YzllMGEyNDk0NmQ5ZmExYjdlYTQ1NmY2In0=
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2025
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 17, 2025 23:05
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 17, 2025 23:05
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2025
@MarkDuckworth
Copy link

@bshaffer, can you review this at your convenience

@Hectorhammett Hectorhammett changed the title fix: [Firestore] bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes feat: [Firestore] bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes Jan 22, 2025
@Hectorhammett
Copy link
Collaborator

@MarkDuckworth
I reviewed as I am in rotation this week. It looks good, I can go ahead and merge it unless you have a specific reason for Brent to review it? :)

@bshaffer bshaffer merged commit 01719f3 into main Jan 24, 2025
31 of 32 checks passed
@bshaffer bshaffer deleted the owl-bot-copy-Firestore branch January 24, 2025 19:26
bshaffer pushed a commit that referenced this pull request Feb 11, 2025
fix: bump default deadline on CreateDatabase and RestoreDatabase to 2 minutes (#8024)
PiperOrigin-RevId: 716763143
Source-Link: googleapis/googleapis@3776db1
Source-Link: googleapis/googleapis-gen@10db5ac
Copy-Tag: eyJwIjoiRmlyZXN0b3JlLy5Pd2xCb3QueWFtbCIsImgiOiIxMGRiNWFjNDc2YTk0YWE0YzllMGEyNDk0NmQ5ZmExYjdlYTQ1NmY2In0=
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants