Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated aliases in double-nested protos #4997

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: remove deprecated aliases in double-nested protos #4997

merged 1 commit into from
Jan 10, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 10, 2022 •
edited
Loading

Matching only one directory deep is missing a lot of classes which need their aliases removed.

For example, see NetworkSecurity/src/V1beta1/AuthorizationPolicy/Rule/Destination.php

The following Services will need to be generated:

@bshaffer bshaffer requested a review from tmatsuo January 10, 2022 20:14
@bshaffer bshaffer requested review from a team as code owners January 10, 2022 20:14
@bshaffer bshaffer mentioned this pull request Jan 10, 2022
Closed
@bshaffer bshaffer merged commit c4c790c into master Jan 10, 2022
@bshaffer bshaffer deleted the fix-aliases-in-all-files branch January 10, 2022 20:41
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @tmatsuo