-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade Guzzlehttp/psr7 version #4508
feat: Upgrade Guzzlehttp/psr7 version #4508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @saranshdhingra! Just one minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great! However, I suggest we split this into two PRs, one with just the updates to Core
, and one with the changes to the other packages which rely on the update to cloud core (namely, Bigquery
, Datastore
, Spanner
, Storage
, and Vision
because they rely on guzzlehttp/psr7:1.7
).
We then merge the PR for Core
, cut a new version (v1.43.0
), and update the composer.json
s for the above packages to depend on google/cloud-core:^1.43
. The packages which do not use the new classes in 1.7
do not need to be updated.
David says we can get away with updating |
Is this fix now available? |
Most of the work is done and the dependencies have been updated. We just need to decide on which route to take re: 'splitting' the PRs before releasing. |
will this fix be applied to google/cloud-pubsub as well? Because it has the same issue. |
@tjhunkin-inhance yes, when this rolls out it will address all of our packages. |
Awesome, thanks |
This PR aims to resolve version dependency issues related to older versions(<1.7) for guzzlehttp/psr7 package. See issue #4247 for details.
The use of deprecated methods have been removed and the dependencies have been upgraded.