Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests required for alpha release #4049

Merged
merged 4 commits into from
Sep 3, 2021
Merged

tests: add tests required for alpha release #4049

merged 4 commits into from
Sep 3, 2021

Conversation

georgiyekkert
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2021
@georgiyekkert georgiyekkert marked this pull request as ready for review May 28, 2021 18:44
@georgiyekkert georgiyekkert requested a review from a team as a code owner May 28, 2021 18:44
@georgiyekkert
Copy link
Contributor Author

@googleapis/yoshi-php please review

bshaffer
bshaffer reviewed Sep 1, 2021
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits, otherwise this looks great!

It will be nice to replace the polling functions once we implement LRO annotation support (see #4438)

@georgiyekkert georgiyekkert requested a review from a team as a code owner September 2, 2021 00:08
@georgiyekkert
Copy link
Contributor Author

Suggestions are applied, double quotes were replaced with single. I'll replace polling as soon as LRO is ready

@bshaffer bshaffer merged commit 55a97b5 into googleapis:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgiyekkert @bshaffer