feat: Move v2 translate client #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
reviewed
Oct 24, 2019
Core/src/ServiceBuilder.php
Outdated
| @@ -30,7 +30,7 @@ | |||
| use Google\Cloud\Speech\SpeechClient; | |||
| use Google\Cloud\Storage\StorageClient; | |||
| use Google\Cloud\Trace\TraceClient; | |||
| use Google\Cloud\Translate\TranslateClient; | |||
| use Google\Cloud\Translate\V2\TranslateClient; | |||
There was a problem hiding this comment.
Is it possible to leave this as use Google\Cloud\Translate\TranslateClient? It is a bit of a gray area, since the classes are identical in practice - but the returned type will vary. If anyone is doing typechecks they might fail.
There was a problem hiding this comment.
yes, but they will get the suppressed E_USER_DEPRECATED notice. I guess you're probably right though, this should be considered breaking.
Codecov Report
@@ Coverage Diff @@
## master #2423 +/- ##
============================================
- Coverage 92.55% 92.47% -0.08%
+ Complexity 4504 4477 -27
============================================
Files 312 312
Lines 13496 13414 -82
============================================
- Hits 12491 12405 -86
- Misses 1005 1009 +4
Continue to review full report at Codecov.
|
dwsupplee
approved these changes
Oct 28, 2019
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
This was referenced Feb 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.