-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(scc-samples): update comments to include new parent types #9596
Conversation
...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up that the SCC Assets API is deprecated and will be replaced by integrating Cloud Asset Inventory's API in SCC. The CAI replacement is expected to GA at the beginning of August. Existing users have a year to move off of the SCC API. SCC's Assets API is disabled for all new users who activate SCC after last week's deprecation notice. New users can only use CAI.
...xamples/src/main/java/com/google/cloud/examples/securitycenter/snippets/FindingSnippets.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/com/google/cloud/examples/securitycenter/snippets/SecurityMarkSnippets.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/com/google/cloud/examples/securitycenter/snippets/SecurityMarkSnippets.java
Outdated
Show resolved
Hide resolved
...examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/SourceSnippets.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments on stuff I missed the first time around
...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/AssetSnippets.java
Outdated
Show resolved
Hide resolved
...xamples/src/main/java/com/google/cloud/examples/securitycenter/snippets/FindingSnippets.java
Outdated
Show resolved
Hide resolved
...examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/SourceSnippets.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we start thinking about moving to java-docs-samples?
Yes, I'm discussing it with the Java samples team and have created a bug for it: 290775040 |
Security Command Center Samples
Contains only comment updates to allow new parent types.