Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute/metadata): add http timeout to metadata client #6499

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

therealmitchconnors
Copy link
Contributor

Fixes #6498

@therealmitchconnors therealmitchconnors requested a review from a team as a code owner August 10, 2022 17:08
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 10, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable request but that is a rather short timeout. Could be make this 5 seconds at least to start. We have similar timeouts elsewhere in this package.

@codyoss codyoss changed the title Add http timeout to metadata client feat(compute/metadata): add http timeout to metadata client Aug 10, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@therealmitchconnors
Copy link
Contributor Author

I think this is a reasonable request but that is a rather short timeout. Could be make this 5 seconds at least to start. We have similar timeouts elsewhere in this package.

I have updated to 5 seconds. Please note that the dial timeout is still set to 2 seconds, so the timeout behavior will vary depending on the specifics.

@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Aug 11, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Aug 11, 2022
@codyoss codyoss enabled auto-merge (squash) August 11, 2022 13:20
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@codyoss codyoss merged commit 37d49f7 into googleapis:main Aug 11, 2022
@release-please release-please bot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata: need http timeout
3 participants