Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix adding multiple range on stream with same read id #11584

Merged
merged 8 commits into from
Feb 24, 2025

Conversation

shubham-diwakar
Copy link
Contributor

Issue:

  1. If we get a read add call we put it in map mr.mp[curentID] = spec
  2. And if at that same point we receive an error from server we go into retry loop and close the stream manager go-routine.
  3. During retry we see this new entry in map which is also retried.
  4. Basically this creates two instances of curentID which we send to server. One due to add call one due to retry.

Fix:

  1. Remove adding the current id in map in add call. As that can create duplicates as seen above.
  2. Ignore the values from server in case entry is not found in map, given user will be notified if an entry is not in map by the help of callback.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 11, 2025
@shubham-diwakar shubham-diwakar marked this pull request as ready for review February 11, 2025 17:23
@shubham-diwakar shubham-diwakar requested review from a team as code owners February 11, 2025 17:23
@shubham-diwakar
Copy link
Contributor Author

Thanks for taking a look!!

@tritone tritone added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 11, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 11, 2025
@tritone tritone added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0bb3434 into googleapis:main Feb 24, 2025
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants