Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): add support for cloud storage ingestion topics #10959

Merged
merged 4 commits into from
Oct 8, 2024
Merged

feat(pubsub): add support for cloud storage ingestion topics #10959

merged 4 commits into from
Oct 8, 2024

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Oct 7, 2024 •
edited
Loading

Adds support for Cloud Storage ingestion in topic create/update.

@hongalex hongalex requested review from shollyman and a team as code owners October 7, 2024 22:09
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 7, 2024
michaelpri10
michaelpri10 reviewed Oct 7, 2024
View reviewed changes
pubsub/topic_test.go Outdated
t.Errorf("\ngot %+v\nwant %+v", config2.IngestionDataSourceSettings, settings)
}

// Clear schema settings.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Clear ingestion settings."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@michaelpri10
Copy link

LGTM

@hongalex hongalex merged commit 1a11675 into googleapis:main Oct 8, 2024
8 checks passed
@release-please release-please bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpri10 michaelpri10 michaelpri10 approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongalex @michaelpri10