From a6eeac7aac4ddb4ae3ded0988a99dc1f7d3adce0 Mon Sep 17 00:00:00 2001 From: cojenco Date: Tue, 7 Jan 2025 15:22:20 -0800 Subject: [PATCH] test(storage): fix emulated tests for metadata on read (#11387) --- storage/client_test.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/storage/client_test.go b/storage/client_test.go index 403a04b84bc1..70803af058c9 100644 --- a/storage/client_test.go +++ b/storage/client_test.go @@ -795,8 +795,8 @@ func TestOpenReaderEmulated(t *testing.T) { }) } -func TestOpenReaderEmulated_Metadata(t *testing.T) { - transportClientTest(context.Background(), t, func(t *testing.T, ctx context.Context, project, bucket string, client storageClient) { +func TestOpenReaderMetadataEmulated(t *testing.T) { + transportClientTest(skipHTTP("metadata on read not supported in testbench rest server"), t, func(t *testing.T, ctx context.Context, project, bucket string, client storageClient) { // Populate test data. _, err := client.CreateBucket(ctx, project, bucket, &BucketAttrs{ Name: bucket, @@ -849,8 +849,13 @@ func TestOpenReaderEmulated_Metadata(t *testing.T) { "Custom-Key": "custom-value", "Some-Other-Key": "some-other-value", } - if diff := cmp.Diff(r.Metadata(), expectedMetadata); diff != "" { - t.Fatalf("Object Metadata: got(-),want(+):\n%s", diff) + gotMetaData := r.Metadata() + // Testbench specific metadata is included for testing purposes. + for key, expectedValue := range expectedMetadata { + actualValue, ok := gotMetaData[key] + if !ok || actualValue != expectedValue { + t.Fatalf("Object Metadata: Expected key %q with value %q, but got %q", key, expectedValue, actualValue) + } } })