fix: allow an empty requestBody to be provided for APIs that support … #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
changed the title
JustinBeckwith
suggested changes
Mar 11, 2020
| @@ -411,13 +411,9 @@ export namespace accesscontextmanager_v1beta { | |||
| */ | |||
| unrestrictedServices?: string[] | null; | |||
| /** | |||
| * Beta. Configuration for within Perimeter allowed APIs. | |||
| * Beta. Configuration for APIs allowed within Perimeter. | |||
There was a problem hiding this comment.
Eugh. Could I trouble you to first submit and land a re-generate PR from master? Would love to see only the relevant changes in this PR. Sorry.
bcoe
commented
Mar 11, 2020
| /** | ||
| * Alpha. Specifies how APIs are allowed to communicate within the Service Perimeter. This message is DEPRECATED and had been renamed to VpcAccessibleServices | ||
| */ | ||
| export interface Schema$VpcServiceRestriction { |
There was a problem hiding this comment.
most of the updates below are the result of running the generator, which tends to change a few existing APIs, regardless of changes to the templates.
| const progressEvents = new Array<number>(); | ||
| await youtube.thumbnails.set( | ||
| { | ||
| videoId: 'abc123', |
There was a problem hiding this comment.
This test demonstrates how to perform a multipart upload with an API that doesn't expect a requestBody.
| @@ -154,6 +154,11 @@ export interface Schema${{ schema.id }} { | |||
| * Request body metadata | |||
| */ | |||
| requestBody?: Schema${{ m.request.$ref }}; | |||
| {% elif m.supportsMediaUpload and m.mediaUpload.protocols.simple.multipart %} | |||
There was a problem hiding this comment.
this is the meat of the change.
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
=======================================
Coverage 38.76% 38.76%
=======================================
Files 6 6
Lines 1068 1068
Branches 8 6 -2
=======================================
Hits 414 414
Misses 654 654 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 11, 2020
bcoe
changed the title
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 11, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [48.0.0](https://github.com/googleapis/google-api-nodejs-client/compare/v47.0.0...v48.0.0) (2020-03-11) ### ⚠ BREAKING CHANGES * removes toolresults_v1. * regenerate all APIs (#1978) ### Features * regenerate all APIs ([#1978](https://github.com/googleapis/google-api-nodejs-client/issues/1978)) ([f0d4913](https://github.com/googleapis/google-api-nodejs-client/commit/f0d49136eaa12838a74a56aa45e08fa870278ae5)) * run the generator (adds: displayvideo, gamesConfiguration, managedidentities, networkmanagement) ([#1989](https://github.com/googleapis/google-api-nodejs-client/issues/1989)) ([8bcb212](https://github.com/googleapis/google-api-nodejs-client/commit/8bcb212fbab43a1e3214da4712b4c3363d1b1285)) ### Bug Fixes * **deps:** update dependency uuid to v7 ([#1970](https://github.com/googleapis/google-api-nodejs-client/issues/1970)) ([fdf096e](https://github.com/googleapis/google-api-nodejs-client/commit/fdf096ee80c87a98b7d20666a2e38996228fbaf1)) * allow an empty requestBody to be provided for APIs that support multipart post ([#1988](https://github.com/googleapis/google-api-nodejs-client/issues/1988)) ([074f641](https://github.com/googleapis/google-api-nodejs-client/commit/074f6417754930cbcbf5589bbcb88549b9f430a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the generator such that an empty
requestBodycan be provided for methods that supportmultipartuploads (determined by checkingm.mediaUpload.protocols.simple.multipart).Most of the Google APIs I looked at require that the first section of the
multipartPOST represents metadata about the upload, e.g.,In testing with the youtube's
thumbnails.set, the upstream API requires that empty metadata be set to perform a multi-part upload (it's my hunch that this behavior will be fairly consistent across APIs). You can now perform a multipart thumbnail upload like so:☝️ this will fire
onUploadProgressevents.fixes: #1820