-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(all): use CheckResponse for media downloads #773
Conversation
If a method supports media downloads use CheckResponse. This method provided extra context to errors if the api follow https://google.aip.dev/193. The storage api will continue to use CheckMediaResponse as it does not conform to the aip due to legacy reasons. Fixes: #752
Ran the generator on cached discovery docs to generate the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, do we have sufficient test coverage to be confident these are still working properly?
Yup, everything should work just fine. We could probably get away with removing CheckMediaResponse all together in the future. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
If a method supports media downloads use CheckResponse. This method
provided extra context to errors if the api follow
https://google.aip.dev/193. The storage api will continue to use
CheckMediaResponse as it does not conform to the aip due to legacy
reasons.
Fixes: #752