Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require grpc-google-iam-v1>=0.14.0 #2327

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 12, 2025

Bump the minimum version of grpc-google-iam-v1 from 0.12.4 to 0.14.0 as google/cloud/parametermanager/v1 requires google.iam.v1.resource_policy_member_pb2 which was only added in 0.14.0. https://github.com/googleapis/python-grpc-google-iam-v1/releases/tag/v0.14.0

See PR googleapis/google-cloud-python#13500 which has a failing presubmit with the following error

https://github.com/googleapis/google-cloud-python/actions/runs/13272326377/job/37054446432?pr=13500

==================================== ERRORS ====================================
_ ERROR collecting tests/unit/gapic/parametermanager_v1/test_parameter_manager.py _
ImportError while importing test module '/home/runner/work/google-cloud-python/google-cloud-python/packages/google-cloud-parametermanager/tests/unit/gapic/parametermanager_v1/test_parameter_manager.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/gapic/parametermanager_v1/test_parameter_manager.py:54: in <module>
    from google.iam.v1 import resource_policy_member_pb2  # type: ignore
E   ImportError: cannot import name 'resource_policy_member_pb2' from 'google.iam.v1' (/home/runner/work/google-cloud-python/google-cloud-python/packages/google-cloud-parametermanager/.nox/unit-3-7-protobuf_implementation-python/lib/python3.7/site-packages/google/iam/v1/__init__.py)

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 12, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 12, 2025
@parthea parthea requested a review from ohmayr February 12, 2025 17:03
@parthea parthea marked this pull request as ready for review February 12, 2025 17:03
@parthea parthea requested a review from a team as a code owner February 12, 2025 17:03
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2025
@parthea parthea merged commit d4236c8 into main Feb 12, 2025
126 checks passed
@parthea parthea deleted the update-min-version-for-grpc-google-iam-v1 branch February 12, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants