Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate if proto-plus to protobuf response conversion is needed for a streaming response. #2189

Open
ohmayr opened this issue Sep 20, 2024 · 0 comments
Open

investigate if proto-plus to protobuf response conversion is needed for a streaming response. #2189

ohmayr opened this issue Sep 20, 2024 · 0 comments
Assignees
@ohmayr
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 20, 2024

For a proto plus method, we do the following type conversion for a non-streaming response:

pb_resp = {{method.output.ident}}.pb(resp)

We need to investigate if this is needed for a streaming response for both sync and async REST.

Related PR: #1428
@ohmayr ohmayr mentioned this issue Sep 20, 2024
Merged
@ohmayr ohmayr added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ohmayr