Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry and timeout values do not propagate in requests during pagination #2065

Merged
merged 5 commits into from
Jul 23, 2024
Merged

fix: retry and timeout values do not propagate in requests during pagination #2065

merged 5 commits into from
Jul 23, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 22, 2024

Fixes #1664 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 22, 2024
@parthea parthea force-pushed the propagate-retry-timeout branch 5 times, most recently from 15f0375 to be0a668 Compare July 23, 2024 00:38
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 23, 2024
@parthea parthea force-pushed the propagate-retry-timeout branch from 3777c03 to ec2d718 Compare July 23, 2024 01:18
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@parthea parthea force-pushed the propagate-retry-timeout branch from 482df1a to 98cbfd6 Compare July 23, 2024 01:34
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@parthea parthea marked this pull request as ready for review July 23, 2024 01:43
@parthea parthea requested a review from a team as a code owner July 23, 2024 01:43
@parthea parthea assigned ohmayr and vchudnov-g and unassigned vchudnov-g Jul 23, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@parthea parthea merged commit 76aa98e into main Jul 23, 2024
67 checks passed
@parthea parthea deleted the propagate-retry-timeout branch July 23, 2024 17:39
@release-please release-please bot mentioned this pull request Jul 19, 2024
Merged
@daniel-sanche daniel-sanche mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@vchudnov-g vchudnov-g

@ohmayr ohmayr

Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retry and timeout values do not propagate in requests during pagination
3 participants
@parthea @ohmayr @vchudnov-g