Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disambiguate method names #1282

Merged
merged 4 commits into from
Apr 20, 2022
Merged

fix: disambiguate method names #1282

merged 4 commits into from
Apr 20, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 19, 2022

Fixes #1277

@parthea parthea force-pushed the disambiguate-method-names branch 2 times, most recently from a47fa18 to 40364f5 Compare April 19, 2022 16:16
@parthea parthea force-pushed the disambiguate-method-names branch from 40364f5 to 12e53ef Compare April 19, 2022 16:24
@parthea parthea marked this pull request as ready for review April 19, 2022 16:25
@parthea parthea requested review from a team as code owners April 19, 2022 16:25
vam-google
vam-google approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2022
@snippet-bot
Copy link

snippet-bot bot commented Apr 19, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2022
@parthea parthea self-assigned this Apr 19, 2022
@parthea parthea merged commit efe7216 into main Apr 20, 2022
@parthea parthea deleted the disambiguate-method-names branch April 20, 2022 17:01
@release-please release-please bot mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

Assignees

@parthea parthea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error in generated client for sqladmin v1
2 participants
@parthea @vam-google