feat(gengapic): REGAPIC retry support #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to hold off on submitting this PR until gax-go v2.4.0 has landed in google-cloud-go. Don't want any accidental regens with this producing broken code or blocking integration of a fix. |
|
FYI: Rebased onto main in order to fix merge conflicts with #994 |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.2...v0.30.0) (2022-06-01) ### Features * **gengapic:** REGAPIC retry support ([#993](#993)) ([4021354](4021354)) ### Bug Fixes * **bazel:** add missing regapic dep to go_library ([#1016](#1016)) ([ba270da](ba270da)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds generation for default retry config for REGAPIC clients. The status codes in the retry configuration used today for gRPC are converted into HTTP status codes according to a canonical mapping that all languages are using.
Fixes #843.