Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gengapic): diregapic lro polling request params #876

Merged
merged 4 commits into from
Jan 31, 2022
Merged

feat(gengapic): diregapic lro polling request params #876

merged 4 commits into from
Jan 31, 2022

Conversation

noahdietz
Copy link
Collaborator

No description provided.

@noahdietz noahdietz requested review from a team as code owners January 28, 2022 20:00
codyoss
codyoss reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things.

internal/gengapic/custom_operation.go Outdated Show resolved Hide resolved
internal/gengapic/custom_operation.go Outdated Show resolved Hide resolved
internal/gengapic/custom_operation.go Outdated Show resolved Hide resolved
@noahdietz noahdietz requested a review from codyoss January 28, 2022 20:50
codyoss
codyoss approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit fd0a07b into googleapis:main Jan 31, 2022
@noahdietz noahdietz deleted the diregapic-poll-fields branch January 31, 2022 19:12
@release-please release-please bot mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @codyoss