Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support wrapper types for autopagination #1541

Merged
merged 14 commits into from
Aug 15, 2024

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 24, 2024

This PR widens support for autopagination in the go gapic generator. Changes:

  • enable autopaging detection to include wrapper types in the heuristic
  • allowlist control for enabling wrapper support based on proto package name
  • templating changes for support
  • augment the autopagination denylist to avoid generating a paginatinated signature for an additional API/method

Things still outstanding:

  • Testing depth: this validates detection, but doesn't expand goldens testing to use a wrapper-based list RPC. That said, we only expect the single service to leverage this, and I have verified the generated client out of band.

@shollyman shollyman requested a review from noahdietz August 8, 2024 17:02
@noahdietz noahdietz requested review from quartzmo and removed request for noahdietz August 8, 2024 17:03
@shollyman
Copy link
Contributor Author

looks like the showcase testing in integration testing is broken in general, not due to this PR: #1552

@shollyman shollyman marked this pull request as ready for review August 8, 2024 17:27
@shollyman shollyman requested review from a team as code owners August 8, 2024 17:27
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This latest revision improves this PR a lot! I'm impressed with how much easier it is to understand. Approving, with nit for one docs typo.

internal/gengapic/paging.go Outdated Show resolved Hide resolved
@shollyman shollyman added the automerge Summon MOG for automerging label Aug 15, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit d10df59 into googleapis:main Aug 15, 2024
7 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 15, 2024
@shollyman shollyman deleted the paging-changes branch August 15, 2024 20:03
codyoss added a commit to codyoss/gapic-generator-go that referenced this pull request Aug 16, 2024
codyoss added a commit to codyoss/gapic-generator-go that referenced this pull request Aug 16, 2024
codyoss added a commit to codyoss/gapic-generator-go that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants