Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: remove maybeUnknownEnum error checker and usage #1302

Closed
noahdietz opened this issue Apr 17, 2023 · 0 comments · Fixed by #1358
Closed

gapic: remove maybeUnknownEnum error checker and usage #1302

noahdietz opened this issue Apr 17, 2023 · 0 comments · Fixed by #1358
Assignees
@noahdietz
Labels
type: cleanup An internal cleanup or hygiene concern.
Milestone
Go GAPIC Moderniz...

Comments

@noahdietz
Copy link
Collaborator

The maybeUnknownEnum helper was meant as a stop gap until rest-numeric-enum support was rolled out, which it has been. So this helper should be removed along with the generated usages of it in REGAPIC clients.
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 17, 2023
@noahdietz noahdietz added this to the Go GAPIC house keeping milestone Apr 17, 2023
@noahdietz noahdietz self-assigned this Jun 5, 2023
@noahdietz noahdietz mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
Go GAPIC Modernization
Development

Successfully merging a pull request may close this issue.

fix(gengapic): remove unknown enum error helper noahdietz/gapic-generator-go
1 participant
@noahdietz