fix: add time import for compute operations #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe without the deadline code time was no longer being included here or something. Tested locally and the target now compiles again with this change
|
I am not sure if the compute test still provides us value or not. I removed for now because gapicgen can no longer generate it, but I am sure we could make a googleapis style test if needed. I did swap these changes into googleapis though and the gapic target now builds again. |
quartzmo
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe without the deadline code time was no longer being included here or something. Tested locally and the target now compiles again with this change
Also removed the compute regen test as compute can no longer be regenerated with the old tooling.