This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
fix: Fix PathTemplate custom verb logic matching and instantiating #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom verb (":literal" at the end of a url path) was not handled properly. On instantiation `:` was incorrectly replaced with `/`. On matching `:literal` was not properly recognized as a valid input.
google-cla
bot
added
the
cla: yes
elharo
approved these changes
Jul 18, 2021
miraleung
approved these changes
Jul 18, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.10.5](https://github.com/googleapis/api-common-java/compare/v1.10.5...v1.10.5) (2021-07-27) ### Bug Fixes * Fix PathTemplate custom verb logic matching and instantiating ([#244](https://github.com/googleapis/api-common-java/issues/244)) ([d4913d3](https://github.com/googleapis/api-common-java/commit/d4913d33ff2153cb3a8f6382ab8d918980f542ea)) ### Build System * migrate to google sonatype endpoint ([#248](https://github.com/googleapis/api-common-java/issues/248)) ([c3ab73e](https://github.com/googleapis/api-common-java/commit/c3ab73eca99f3036a26fe10a880c1ff068efc0da)) ### Dependencies * update dependency com.google.auto.value:auto-value to v1.8.2 ([#242](https://github.com/googleapis/api-common-java/issues/242)) ([5de2f3e](https://github.com/googleapis/api-common-java/commit/5de2f3edfcaed42061ad7dbc4efc886587c0e769)) * update dependency com.google.auto.value:auto-value-annotations to v1.8.2 ([#243](https://github.com/googleapis/api-common-java/issues/243)) ([53d6d38](https://github.com/googleapis/api-common-java/commit/53d6d38ac0a7d6dc5738823d69ac96d1eadd23a3)) * update dependency com.google.errorprone:error_prone_annotations to v2.8.0 ([#245](https://github.com/googleapis/api-common-java/issues/245)) ([8889689](https://github.com/googleapis/api-common-java/commit/88896894b821771293cda2d4b7a2f6027ee20ef4)) * update dependency io.codearte.gradle.nexus:gradle-nexus-staging-plugin to v0.30.0 ([#239](https://github.com/googleapis/api-common-java/issues/239)) ([2ca4359](https://github.com/googleapis/api-common-java/commit/2ca4359127cc2f8eddb81e8091362a75e1e6e38e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom verb (
:literalat the end of a url path) was not handled properly. On instantiation:was incorrectly replaced with/. On matching:literalwas not properly recognized as a valid input.Also specified the jacoco version explicitly (points to the latest version on the moment of creation of this PR). Without this chagne jacoco was failing on
jdk11+(worked onjdk8that is why CI was succeeding).