Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang #8059

Closed
jonathanmetzman opened this issue Jul 22, 2022 · 6 comments
Closed

Update clang #8059

jonathanmetzman opened this issue Jul 22, 2022 · 6 comments

Comments

@jonathanmetzman
Copy link
Contributor

Theres a few different reasons why we should update clang

  • discrepancies between what is used in the rest of Google and OSS-Fuzz
  • needing a newer version of clang for centipede

We're currently on clang-14.
@vanhauser-thc Do you know if we can upgrade to 15 with AFL++ (sorry for asking this again, can't remember your answer)

@vanhauser-thc
Copy link
Contributor

yes you can upgrade. Our LTO instrumentation doesnt work on llvm 15 as they removed the ability to load own plugins in lld, but LTO is not used (and doesn't make sense to be used) in clusterfuzz.
however they might always change something in llvm 15-dev that breaks external plugins like ours.
But native clang-15 already broke a few configure scripts for things I wanted to compile normally :)

@evverx
Copy link
Contributor

evverx commented Aug 5, 2022

We're currently on clang-14.

@jonathanmetzman as far as I can see llvm/llvm-project@bc56097 hasn't been included in the base-builder image yet so it seems clang is pinned somewhere between clang-13 and clang-14 on OSS-Fuzz. I wonder if it would be possible to bump it to 14? I saw #8108 but looks like it might take a while.

@jonathanmetzman
Copy link
Contributor Author

We are currently on clang 14 aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7

@jonathanmetzman
Copy link
Contributor Author

I don't think it should take longer than a week or two to update to clang 15 so I don't think we will do anything temporary in the meantime

@evverx
Copy link
Contributor

evverx commented Aug 5, 2022

That commit is older than llvm/llvm-project@bc56097. The problem is that distributions ship clang-14 with both those commits included and there it's kind of safe to assume that -fno-semantic-interposition doesn't work with -fuzzer-no-link with clang < 14. On OSS-Fuzz that assumption isn't correct so it should be handled differently. More generally it would be great if OSS-Fuzz pinned clang to tags pointing to releases instead of release candidates.

I don't think we will do anything temporary in the meantime

Fair enough.

@maflcko
Copy link
Contributor

maflcko commented Jun 13, 2023

Can be closed, now that the discussion moved to #9989?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants