Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fidelity tests to use new default environment lighting #521

Closed
cdata opened this issue May 2, 2019 · 2 comments · Fixed by #630
Closed

Change fidelity tests to use new default environment lighting #521

cdata opened this issue May 2, 2019 · 2 comments · Fixed by #630

Comments

@cdata
Copy link
Contributor

cdata commented May 2, 2019

When we added Khronos models to our fidelity tests in #360 , we made a decision to use an environment map when staging most of them because our default environment lighting was pretty bad and Filament had no default IBL. As of #472 we have much improved default lighting conditions in <model-viewer>. We should change the environment lighting used in our tests to be based on the new default.

@cdata
Copy link
Contributor Author

cdata commented May 2, 2019

Here is an archive containing the equirectangular HDR environment map equivalent of the default lighting currently being used in <model-viewer>: lightroom_14b.zip

The three files included are:

  • lightroom_14b.exr - original, in EXR format
  • lightroom_14b.hdr - converted to HDR format
  • lightroom_14b_offset.hdr - HDR offset by 90º

@elalish
Copy link
Contributor

elalish commented Jun 7, 2019

@cdata I'm guessing we'll still want to keep a few with other environment maps, just for breadth of testing, right? Anyway, this also seems like good fodder for the 0.5 rendering work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants