Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control interaction prompt appears too quickly in most cases #435

Closed
cdata opened this issue Mar 17, 2019 · 0 comments · Fixed by #452
Closed

Control interaction prompt appears too quickly in most cases #435

cdata opened this issue Mar 17, 2019 · 0 comments · Fixed by #452
Assignees

Comments

@cdata
Copy link
Contributor

cdata commented Mar 17, 2019

We have a visual and audible (to screen readers) interaction prompt that appears after a fixed time (currently 3 seconds) of idleness starting when <model-viewer> is focused. In many cases, <model-viewer> will be focused as soon as it appears in the document. In this case, we begin measuring idleness even though the model has not finished loading. The result of this is that the visual prompt might appear before or near to when the model has appeared to the user.

We should fix this by only measuring idleness once the model has finished loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant