Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOI Editor] Include LOI changes with publish job action #1895

Closed
jcqli opened this issue Jul 2, 2024 · 1 comment
Closed

[LOI Editor] Include LOI changes with publish job action #1895

jcqli opened this issue Jul 2, 2024 · 1 comment
Labels
type: fr Request for new feature web Angular implementation of Web UI
Milestone

Comments

@jcqli
Copy link

jcqli commented Jul 2, 2024

When LOIs are imported for a job that is not published, they do not show up in the map as they are not associated with any jobs.

We can bundle the import/delete LOI action within the publish job action:

[ ] Add a state to each LOI and manage the states so that in the edit job phase
[ ] user import LOIs, LOIs shows in edit page, user clicks publish button => LOIs shows in map page
[ ] user import LOIs, LOIs shows in edit page, user quits editing without clicking publish => LOIs does not show in map page
[ ] user delete LOIs, LOIs does not show in edit page, user clicks publish button => LOIs does not show in map page
[ ] user delete LOIs, LOIs does not show in edit page, user quits editing without clicking publish => LOIs shows in map page
[ ] Same behavior should happen to a new unpublished job

More context: #1714 (comment)

@jcqli
Copy link
Author

jcqli commented Aug 12, 2024

Duplicate of #1964, using that one to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fr Request for new feature web Angular implementation of Web UI
Projects
Status: Done
Development

No branches or pull requests

2 participants