Put documentation to bfbs if it is not empty #7649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from google/flatbuffers
If a struct has a key the vector has to be sorted. To sort the vector you can't use "const".
* option indent_step is supported
Pull from google
Why they are different when generating it with linux and windows executable?
|
Linux and windows flatc should generate same files. But bfbs files seams to be different when generated. Why this is the case? Generating the monster test files under linux fixed the build break. |
|
Seems simple enough! |
dbaileychess
approved these changes
Nov 17, 2022
|
Linux` and windows flatc should generate same files. But bfbs files seams to be different when generated. Why this is the case? Generating the monster test files under linux fixed the build break. Is it because of the different path separators? |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fix C/C++ Create<Type>Direct with sorted vectors If a struct has a key the vector has to be sorted. To sort the vector you can't use "const". * Changes due to code review * Improve code readability * Add generate of JSON schema to string to lib * option indent_step is supported * Remove unused variables * Fix break in test * Fix style to be consistent with rest of the code * [TS] Fix reserved words as arguments (google#6955) * [TS] Fix generation of reserved words in object api (google#7106) * [TS] Fix generation of object api * [TS] Fix MakeCamel -> ConvertCase * [C#] Fix collision of field name and type name * [TS] Add test for struct of struct of struct * Update generated files * Add missing files * [TS] Fix query of null/undefined fields in object api * Put documentation to bfbs if it is not empty * Fix monster test bfbs reference files * Fix generated monster test files Why they are different when generating it with linux and windows executable?
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fix C/C++ Create<Type>Direct with sorted vectors If a struct has a key the vector has to be sorted. To sort the vector you can't use "const". * Changes due to code review * Improve code readability * Add generate of JSON schema to string to lib * option indent_step is supported * Remove unused variables * Fix break in test * Fix style to be consistent with rest of the code * [TS] Fix reserved words as arguments (google#6955) * [TS] Fix generation of reserved words in object api (google#7106) * [TS] Fix generation of object api * [TS] Fix MakeCamel -> ConvertCase * [C#] Fix collision of field name and type name * [TS] Add test for struct of struct of struct * Update generated files * Add missing files * [TS] Fix query of null/undefined fields in object api * Put documentation to bfbs if it is not empty * Fix monster test bfbs reference files * Fix generated monster test files Why they are different when generating it with linux and windows executable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "--bfbs-comments" every struct, field, enum, ... gets an documentation in bfbs even if there is no documentation in fbs file. This leads to unnecessary entries in bfbs files without adding value. This PR fixes this issue (#7639).