[C#] Fix collision of field name and type name #7149
Merged
+107
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from google/flatbuffers
If a struct has a key the vector has to be sorted. To sort the vector you can't use "const".
* option indent_step is supported
19 tasks
|
Hello can you try pulling to fix CI? |
|
Are there any changes to the generated files? |
|
There are changes in the generated files. But current tests did not cover these changes. So currently generated files in this repo did not change. Should i somewhere add testcases to display changes? |
|
You could add a test schema with collisions and the associated build automation |
|
@tira-misu ping about @CasperN suggestions. |
|
pong Sorry for late delivery. |
dbaileychess
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix collision of field names and type names in C# in object api.