Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

iOS / ENX redirect #1463

Closed
mikehelmick opened this issue Dec 28, 2020 · 2 comments · Fixed by #1466
Closed

iOS / ENX redirect #1463

mikehelmick opened this issue Dec 28, 2020 · 2 comments · Fixed by #1466
Assignees
Labels
kind/bug Something is malfunctioning.

Comments

@mikehelmick
Copy link
Contributor

TL;DR

We need a new setting for iOS where a custom app and ENX co-exist.

That setting is to not redirect to the app store if a redirect request reaches the redirect server AND there is iOS metadata.

If EN Express is enabled && there is an iOS app, we should still build the ens:// URL because if the custom app was installed, it would have grabbed the link.

@mikehelmick mikehelmick added the kind/bug Something is malfunctioning. label Dec 28, 2020
@mikehelmick mikehelmick added this to the v0.19.0 milestone Dec 28, 2020
@sethvargo sethvargo changed the title iOS / EN Expres redirect iOS / ENX redirect Dec 28, 2020
@sethvargo
Copy link
Member

/assign

@sethvargo
Copy link
Member

Added in #1466. FWIW, I think we have a bug in the current implementation in that there's no checking to see if ENX is enabled.

If the user provides a valid user agent for iOS or Android and there's no app registered, the current behavior is to redirect to the ens:// link, even if the realm doesn't have enx enabled. That's fixed in the PR too.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something is malfunctioning.
Projects
None yet
2 participants