Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu does not switch sides when the site changes to RTL #2011

Closed
Tracked by #1442
mboukhalfa opened this issue May 19, 2024 · 2 comments · Fixed by #2018
Closed
Tracked by #1442

The menu does not switch sides when the site changes to RTL #2011

mboukhalfa opened this issue May 19, 2024 · 2 comments · Fixed by #2018
Labels
bug Something isn't working i18n Internationalization / Localization
Milestone

Comments

@mboukhalfa
Copy link
Contributor

Problem

When switching to Persian (RTL lang) the menu does not change direction as shown in the pictures when we switch to RTL the logo and the search input switch the side but the menu stick to its place instead of moving to left side.

ref: twbs/bootstrap#22780 (comment)
Screenshot from 2024-05-19 04-04-38
Screenshot from 2024-05-19 04-04-54

The root of the issue

ms-md-auto class to push the menu always to the right does not support direction change

@mboukhalfa mboukhalfa added bug Something isn't working needs-triage labels May 19, 2024
@chalin chalin added i18n Internationalization / Localization and removed needs-triage labels May 28, 2024
@chalin
Copy link
Collaborator

chalin commented May 28, 2024

For the record, this was reported earlier too:

@chalin
Copy link
Collaborator

chalin commented May 29, 2024

For a confirmation of the fix, see:

/cc @theletterf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working i18n Internationalization / Localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants