Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race between OnDemandHousekeeping and housekeepingTick #2754

Closed
pkagrawal opened this issue Dec 7, 2020 · 1 comment · Fixed by #2755
Closed

Data race between OnDemandHousekeeping and housekeepingTick #2754

pkagrawal opened this issue Dec 7, 2020 · 1 comment · Fixed by #2755

Comments

@pkagrawal
Copy link
Contributor

statsLastUpdatedTime which is part of the containerData struct is read from OnDemandHousekeeping and written to in housekeepingTick. These could be running under different go routines and so need to be guarded by the containerData lock.
@pkagrawal pkagrawal mentioned this issue Dec 7, 2020
Merged
@iwankgb
Copy link
Collaborator

iwankgb commented Dec 12, 2020

What version of cAdvisor are you using? Is this standalone process or part of kubelet (or any other application)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race between OnDemandHousekeeping and housekeepingTick pkagrawal/cadvisor
2 participants
@iwankgb @pkagrawal