-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "required" text for required fields in Questionaire #544
Comments
@jingtang10 If you like the feature, then may I start with it. |
#470 ? |
@Manikant25 thanks for raising this - this is now an urgent need from two implementers. @Manikant25 please feel free to send a pr asap - if you don't have time @santosh-pingle will work on this. |
sure, I will try to send the PR by the end of this weekend. |
@shelaghm can you please comment on the UX design of this issue? |
This makes sense to me. I assume it will also be important to pair the astericks From a UX perspective I recommend making the |
@Manikant25 Any updates would you like to share on it? |
Looking into it. |
also just confirming that we don't want to show the asterisk in red anywhere right? just following the question text color. |
@jingtang10 Yes, that's right. A few participants in the usability study were confused and thought since it was red that it meant there was an error. So I recommend changing it to same color as the text string to reduce confusion and not associate it with the error color. |
cool thanks for confirming @shelaghm |
talked with @shelaghm on wednesday, i think we're thinking of jsut not showing the asterisk at all, and just use the required string. |
@rowo What are your thoughts on this? |
@dubdabasoduba required questions should have no special treatment i.e * @shelaghm any thoughts on this? |
Thanks @HenryRae for adding your thoughts and raising that Optional might be a better pattern to follow.
My question for the group is if there's still value in having the opportunity to mark questions as required? |
As a principle for form content, I think (and try to convince health teams) that anything optional should just be removed for CHWs. And it's the case that there are only a few optional questions most of the time I've seen. Though, it is safer to have an option for marking required questions to cover of all the bases and I guess I could think of times where people would want to use it. Maybe in forms that aren't done often and maybe more for settings/options or communication preferences? I wonder how much complexity it adds to people trying to configure the app. Are we able to default with the guideline approach? Is this a per form configuration (rather than entire app)? |
@rowo
Thanks for chiming in with your experience and reflections. From a questionnaire authoring perspective, questions are indicated as I'm weary of that the FHIR SDK needs to work across different country contexts, use cases and users, so I don't want to hastily remove functionality that's critical for some developers. Seeing I'm leaning towards that the default should be to not show anything additional for required questions (eg no Will discuss with @jingtang10 when he's back to make a decision on next steps. |
Aligned with @jingtang10 |
Let me just add that FHIR by default assumes questions are not required unless stated otherwise. So that is at odds with the pattern Roger described which is that questions should be required by default and there should be as few optional questions as possible. So I think we probably would have to be a bit neutral here - as in not assuming most questions are required by default, or optional by default. And if we want to do anything, as Shelagh said, we'd probably make it configurable. |
@HenryRae shared with me that at Ona they would like to add the required asterisk within the placeholder of textfield (not at the end of the question title.) I know we had discussed that if there is no question title that the required label would be displayed as part of the text field placeholder. When thinking about making this component configurable, this would be another aspect to consider where the required label would be placed. @santosh-pingle Would this be possible in our existing/current approach? |
Looking into it. |
|
@jingtang10 Pass a boolean value of 'true' as an argument in the bundle to differentiate the optional questions. e.g |
One approach is to pass 'true' as the value to the 'labelPlaceholder' argument in the bundle for the QuestionnaireFragment. If the value is not present, it will be shown next to the question text. |
Closing this issue as I have opened issue #1954. thanks! |
Is your feature request related to a problem? Please describe.
No this is just an enhancement.
Describe the solution you'd like
Asterisks symbol can be added for the fields which have an attribute
"required": "true"
.*
indicates required fields as seen in the sample below.Describe alternatives you've considered
NA
Additional context
NA.
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: