Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap FHIREngine API calls with "withContext(Dispatcher.IO) {}" #2556

Closed
MJ1998 opened this issue May 30, 2024 · 0 comments · Fixed by #2557
Closed

Wrap FHIREngine API calls with "withContext(Dispatcher.IO) {}" #2556

MJ1998 opened this issue May 30, 2024 · 0 comments · Fixed by #2557
Assignees
@MJ1998
Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue

Comments

@MJ1998
Copy link
Collaborator

MJ1998 commented May 30, 2024

Describe the Issue
The CRUD + Search APIs are suspend function which application can invoke in main thread also. We should wrap these function within `withContext(Dispatcher.IO){}" to ensure that this call runs on IO thread and does not block the Main thread.

Would you like to work on the issue?
@MJ1998 MJ1998 self-assigned this May 30, 2024
@aditya-07 aditya-07 added P2 Medium priority issue effort:medium Medium effort - 3 to 5 days labels May 30, 2024
@MJ1998 MJ1998 mentioned this issue May 30, 2024
Merged
7 tasks
@MJ1998 MJ1998 changed the title Wrap CRUD calls with "withContext(Dispatcher.IO) {}" Wrap FHIREngine API calls with "withContext(Dispatcher.IO) {}" May 31, 2024
@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJ1998 MJ1998

Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap FhirEngine apis within IO Dispatcher MJ1998/android-fhir
2 participants
@aditya-07 @MJ1998