Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide previous and next button #2394

Closed
FikriMilano opened this issue Jan 1, 2024 · 6 comments · Fixed by #2397
Closed

Hide previous and next button #2394

FikriMilano opened this issue Jan 1, 2024 · 6 comments · Fixed by #2397
Assignees
Labels
P2 Medium priority issue

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Jan 1, 2024

Is your feature request related to a problem? Please describe.
Would like for the next and previous button to be hidden i.e. when the user is in the first and last page (see image below)

Describe the solution you'd like
Simply hide them (as we agreed)

Describe alternatives you've considered
Configure the buttons visibility, might be overkill

Additional context
wait-what

Would you like to work on the issue?
Yes

@FikriMilano
Copy link
Collaborator Author

@f-odhiambo @rowo

@aditya-07 aditya-07 moved this from New to In Progress in Android FHIR SDK Jan 2, 2024
@aditya-07 aditya-07 added the P2 Medium priority issue label Jan 2, 2024
@jingtang10
Copy link
Collaborator

@FikriMilano can you fix the screenshot? i can't see it.

@jingtang10
Copy link
Collaborator

@shelaghm fyi

@jingtang10
Copy link
Collaborator

as commented in the PR, i wonder if we should simply always hide these buttons.

@shelaghm @rowo any thoughts on this one?

@FikriMilano
Copy link
Collaborator Author

@jingtang10 image fixed

@rowo
Copy link
Collaborator

rowo commented Jan 16, 2024

@jingtang10 agree we should always hide since disabled states imply there exists situations where the user would be allowed to interact with a button/component whereas at the start/end of forms, the previous and next functionalities do not even exist — so the buttons should be hidden.

@FikriMilano FikriMilano changed the title Configure next and previous button visibility when disabled Hide previous and next button Jan 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Complete in Android FHIR SDK Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

4 participants